Transport for London integration

liamgarrison commented 4 years ago

Fixes #3

Old PR with comments here: #221

willtonkin commented 4 years ago

‼️ Note for reviewer be sure to Squash and merge history on merge to loose the apiKey in master

CC: @martincollignon @corradio

corradio commented 4 years ago

Terrific! Are you able to add icons as well?

martincollignon commented 4 years ago

@corradio will you add the apiKey in /env and avg bus ride somewhere? :)

liamgarrison commented 4 years ago

Terrific! Are you able to add icons as well?

I've added icons now

willtonkin commented 4 years ago

This is fantastic! Well done @liamgarrison

Heads up @corradio: History doesn’t appear to have been squashed — https://github.com/tmrowco/tmrowapp-contrib/commit/427e5110d9de0fb80d0ce327d99032fec1477b96

corradio commented 4 years ago

Indeed I'll look into that. I thought I had set defaults to squash/merge

liamgarrison commented 4 years ago

Thanks guys! This is actually the first time I’ve made a PR on an open source project, so cheers for the help. Will see what other integrations I can get stuck in with

corradio commented 4 years ago

Thank you!

On Wed, Oct 30, 2019 at 8:15 AM Liam Garrison notifications@github.com wrote:

Thanks guys! This is actually the first time I’ve made a PR on an open source project, so cheers for the help. Will see what other integrations I can get stuck in with

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tmrowco/tmrowapp-contrib/pull/228?email_source=notifications&email_token=AAMUIKH635KP4V5XTB5NUCTQREYA7A5CNFSM4JF742RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECTEMNA#issuecomment-547767860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUIKET2LQHQLHN5UBX663QREYA7ANCNFSM4JF742RA .

--

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

electricitymaps / bloom-contrib

Transport for London integration #228