search

electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
435 stars 104 forks source link

Add car models #254

Closed ayakoaohara closed 4 years ago

ayakoaohara commented 4 years ago

246 Improved car models by adding fossil fueled cars, electrical cars, and hybrid cars.

I also modified a comment on TRANSPORTATION_MODE_BUS. (Previously, it indicated that emissions production was included in carbon intensity. However, the PDF source seems to indicate as separate.)

martincollignon commented 4 years ago

Thanks Ayako! This is great. I won't merge yet as we're in the midst of a bigger change: we think it'd be better to use the source indicated here: #246 , including the size of vehicles. What I believe we need to do is the same as the flights model (have a separate car.js file) as we also would love to include the data from https://climobil.connecting-project.lu/

ayakoaohara commented 4 years ago

Thank you for your response. Can I help out on writing car.js?

martincollignon commented 4 years ago

You are more than welcome to take a stab at it. The idea is that we'd have two models: one for generic cars (based on size + engine type from DEFRA, with the sources in #246 ) and another one specifically for brand|model|year (based on the https://climobil.connecting-project.lu/ data), based on what input we get from an activity.

ayakoaohara commented 4 years ago

I opened a new pull request to add co2eq/car.js in #258 . In order to avoid confusion, I am closing this pull request.