electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
436 stars 104 forks source link

Uber Facebook login redirect doesn't work on mobile devices #279

Open corradio opened 4 years ago

corradio commented 4 years ago

To reproduce:

Also seems to happen on Android. Works fine from a desktop browser.

corradio commented 4 years ago

Simpler reproducible case:

After some digging I found that this error occurs: image

which comes from a token verification code from uber after the facebook redirect: image

I found that decodeURIComponent(n) yields {"query":"?breeze_local_zone=dca1, which obviously is a truncated JSON containing incomplete info. n is coming from t.fbstate -- would that mean the facebook state returned is invalid?

..that's just weird as variable o is not even used.

@willtonkin have you seen such madness? This only happens when mobile mode is enabled (i.e. probably when user-agent changes)

corradio commented 4 years ago

@FelixDQ said:

It looks like this is a problem on Uber's side. Going directly to https://m.uber.com on a phone and trying to login with facebook also doesn't work.