electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

replaced source lables with publication instead of title of the publication #313

Closed ovbm closed 4 years ago

ovbm commented 4 years ago

Problem it solves: Screenshot 2020-01-27 at 17 11 41

Also the titles are probably less relevant to users than the sources (publication) So: "Environmental impact of omnivorous, ovo-lacto-vegetarian, and vegan diet" becomes "Nature 2017"

martincollignon commented 4 years ago

We may have an issue as some publications request that their work is "properly" cited. I can approve but I think we may need another way long-term . For example accordion component for sources?

corradio commented 4 years ago

For what it's worth, I think the title should stay there as "Nature, 2017" doesn't mean a lot. Citations in academic papers usually bear the title. I would have suggested to change the ux to tolerate such long names. However I don't want to block. Move ahead if you need to.

On Monday, January 27, 2020, martincollignon notifications@github.com wrote:

@martincollignon approved this pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tmrowco/tmrowapp-contrib/pull/313?email_source=notifications&email_token=AAMUIKG4BB4GHF5XDV3CZK3Q74EQDA5CNFSM4KMEHVHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTFFQ6I#pullrequestreview-348805241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUIKABQ53SLA6RKX3AFJLQ74EQDANCNFSM4KMEHVHA .

--

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

ovbm commented 4 years ago

I think having a title without a date and the publications title (current solution) is arguably even worse in terms of "proper citing" than putting the title without any other info.

corradio commented 4 years ago

You're right. I'd vote for scientific paper style citation, with title & year. Again, feel free to move ahead with the solution you deem superior.

On Mon, Jan 27, 2020 at 6:14 PM Olivier Baumann notifications@github.com wrote:

I think having a title without a date and the publications title (current solution) is arguably even worse in terms of "proper citing" than putting the title without any other info.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tmrowco/tmrowapp-contrib/pull/313?email_source=notifications&email_token=AAMUIKF4NV2U2WQH2ANYYTTQ74I6LA5CNFSM4KMEHVHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAJSJI#issuecomment-578853157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUIKASDCNEUU4FB5ODXMDQ74I6LANCNFSM4KMEHVHA .

--

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

ovbm commented 4 years ago

As we're restrained with space, I'm going with "publication_title (year)" I have created a feature in productboard for a long term solution: https://tmrow.productboard.com/feature-board/1122905-feature-prioritization/features/3788937/detail