Updates and automates linting setup

madsnedergaard commented 4 years ago

Goal of this PR

Make linting more consistent and ensures similar standards
Make linting automated and not something anyone has to think about

How this is achieved

Implementsprettier
Implements lint-staged and husky, which means every staged file in a commit will be linted before being commited

Caveats

This will increase the time it takes to add a commit by a few seconds, but a worthy sacrifice IMO :)

Preview

Here's a video showing the effect when committing an un-linted file: https://drive.google.com/file/d/1iu2cbOZWxX1tAldbYPO3wzoSLNjNWFLI/view?usp=sharing

corradio commented 4 years ago

Great! Before merging, might I suggest creating a PR on our main repo that updates the submodule dependency to this branch to make sure those changes will not break our flow once we update the submodule?

madsnedergaard commented 4 years ago

I got a PR ready in mono-repo, in which I will bump contrib when this is merged to master - does that make sense?

corradio commented 4 years ago

Sounds great - I'll wait for all tests to pass before approving.

On Wed, Feb 19, 2020 at 10:05 AM Mads Nedergaard notifications@github.com wrote:

I got a PR ready in mono-repo, in which I will bump contrib when this is merged to master - does that make sense?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/tmrowco/northapp-contrib/pull/334?email_source=notifications&email_token=AAMUIKFGELPR62IZ7QZMNULRDTY4LA5CNFSM4KXDRYL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMG53NA#issuecomment-588111284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUIKAF4FUNHEW2E5MQTDTRDTY4LANCNFSM4KXDRYLQ .

--

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

martincollignon commented 4 years ago

@madsnedergaard can you merge?

electricitymaps / bloom-contrib