search

electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

Fix dependency issue in "playground" that make CI slow #347

Closed madsnedergaard closed 4 years ago

madsnedergaard commented 4 years ago

This reduces CI build time from ~10 min to ~20 seconds, and reduces size of node_modules from ~700mb to ~100mb.

The "contrib": "../" is what's causing crazy nesting - here's an example of what yarn install is doing: Copying "/home/circleci/.cache/yarn/v2/npm-contrib-1.0.0-901f1bdc-87e0-4698-8936-6de2e1de626e-1582714616259/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/domain-browser/HISTORY.md" to "/home/circleci/repo/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/contrib/playground/node_modules/domain-browser/HISTORY.md".

corradio commented 4 years ago

did you test that the playground still works and that it's able to load integrations? if yes, then go ahead and merge! Regardless, kudos on fixing this!

corradio commented 4 years ago

@madsnedergaard I'll let you merge

madsnedergaard commented 4 years ago

Oh hey, thought I had merged this already 🤔 Will do some extra testing of integrations and then merge!