Exiobase model - Githubissues

corradio commented 4 years ago

Ref https://github.com/tmrowco/tmrow/issues/2005

[x] migrate footprint.yml with new categories
[x] migrate definitions.js as a consequence
[x] migrate nordic api gateway
[x] add emission factors to footprint.yml
[x] write a unit test to make sure the model still works
[x] update mapping table for FOOD AND NON-ALCOHOLIC BEVERAGES and CULTURAL SERVICES

corradio commented 4 years ago

@martincollignon here's your review checklist:

[x] definitions.js: make sure the migration is acceptable
[x] nordic api gateway: make sure the migration is acceptable
[x] footprints.yml: make sure the migration is acceptable and that the new numbers make somewhat sense

The readme can be updated in a later PR

cc @thomasgibon, the man who made it all possible. I hope it's ok that we put the notebook here?

corradio commented 4 years ago

For reference these are all the coicop categories for which we have a footprint, but for which we don't have a category in footprints.yml:

WARNING: Could not find an entry with coicopCode 01 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1 in footprints.yml Found 01.1.1. Updating.. WARNING: Could not find an entry with coicopCode 01.1.2 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.3 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.4 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.5 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.6 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.7 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.8 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.9 in footprints.yml WARNING: Could not find an entry with coicopCode 01.2 in footprints.yml Found 02.1. Updating.. Found 02.3. Updating.. Found 03.1. Updating.. WARNING: Could not find an entry with coicopCode 03.2 in footprints.yml WARNING: Could not find an entry with coicopCode 04.1 in footprints.yml WARNING: Could not find an entry with coicopCode 04.2 in footprints.yml WARNING: Could not find an entry with coicopCode 04.3 in footprints.yml WARNING: Could not find an entry with coicopCode 04.4 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.1 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.2 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.3 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.4 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.5 in footprints.yml Found 05.1.1. Updating.. Found 05.1.1.4. Updating.. WARNING: Could not find an entry with coicopCode 05.1.2 in footprints.yml WARNING: Could not find an entry with coicopCode 05.2 in footprints.yml Found 05.3. Updating.. WARNING: Could not find an entry with coicopCode 05.4 in footprints.yml Found 05.5. Updating.. WARNING: Could not find an entry with coicopCode 05.6.1 in footprints.yml WARNING: Could not find an entry with coicopCode 05.6.2 in footprints.yml Found 06.1. Updating.. Found 06.2. Updating.. WARNING: Could not find an entry with coicopCode 06.3 in footprints.yml WARNING: Could not find an entry with coicopCode 07.1 in footprints.yml Found 07.2.1. Updating.. Found 07.2.2. Updating.. Found 07.2.3. Updating.. WARNING: Could not find an entry with coicopCode 07.2.4 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.1 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.2 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.3 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.4 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.5 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.6 in footprints.yml WARNING: Could not find an entry with coicopCode 08 in footprints.yml Found 08.1. Updating.. WARNING: Could not find an entry with coicopCode 09.1 in footprints.yml Found 09.3. Updating.. Found 09.4. Updating.. Found 09.7. Updating.. Found 09.8. Updating.. WARNING: Could not find an entry with coicopCode 10 in footprints.yml WARNING: Could not find an entry with coicopCode 11.1 in footprints.yml Found 11.2. Updating.. WARNING: Could not find an entry with coicopCode 12.1 in footprints.yml WARNING: Could not find an entry with coicopCode 12.2 in footprints.yml Found 13.1. Updating.. WARNING: Could not find an entry with coicopCode 13.2.1 in footprints.yml WARNING: Could not find an entry with coicopCode 13.2.9 in footprints.yml WARNING: Could not find an entry with coicopCode 13.3 in footprints.yml WARNING: Could not find an entry with coicopCode 13.9 in footprints.yml

martincollignon commented 4 years ago

For reference these are all the coicop categories for which we have a footprint, but for which we don't have a category in footprints.yml:

WARNING: Could not find an entry with coicopCode 01 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1 in footprints.yml Found 01.1.1. Updating.. WARNING: Could not find an entry with coicopCode 01.1.2 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.3 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.4 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.5 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.6 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.7 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.8 in footprints.yml WARNING: Could not find an entry with coicopCode 01.1.9 in footprints.yml WARNING: Could not find an entry with coicopCode 01.2 in footprints.yml Found 02.1. Updating.. Found 02.3. Updating.. Found 03.1. Updating.. WARNING: Could not find an entry with coicopCode 03.2 in footprints.yml WARNING: Could not find an entry with coicopCode 04.1 in footprints.yml WARNING: Could not find an entry with coicopCode 04.2 in footprints.yml WARNING: Could not find an entry with coicopCode 04.3 in footprints.yml WARNING: Could not find an entry with coicopCode 04.4 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.1 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.2 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.3 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.4 in footprints.yml WARNING: Could not find an entry with coicopCode 04.5.5 in footprints.yml Found 05.1.1. Updating.. Found 05.1.1.4. Updating.. WARNING: Could not find an entry with coicopCode 05.1.2 in footprints.yml WARNING: Could not find an entry with coicopCode 05.2 in footprints.yml Found 05.3. Updating.. WARNING: Could not find an entry with coicopCode 05.4 in footprints.yml Found 05.5. Updating.. WARNING: Could not find an entry with coicopCode 05.6.1 in footprints.yml WARNING: Could not find an entry with coicopCode 05.6.2 in footprints.yml Found 06.1. Updating.. Found 06.2. Updating.. WARNING: Could not find an entry with coicopCode 06.3 in footprints.yml WARNING: Could not find an entry with coicopCode 07.1 in footprints.yml Found 07.2.1. Updating.. Found 07.2.2. Updating.. Found 07.2.3. Updating.. WARNING: Could not find an entry with coicopCode 07.2.4 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.1 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.2 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.3 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.4 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.5 in footprints.yml WARNING: Could not find an entry with coicopCode 07.3.6 in footprints.yml WARNING: Could not find an entry with coicopCode 08 in footprints.yml Found 08.1. Updating.. WARNING: Could not find an entry with coicopCode 09.1 in footprints.yml Found 09.3. Updating.. Found 09.4. Updating.. Found 09.7. Updating.. Found 09.8. Updating.. WARNING: Could not find an entry with coicopCode 10 in footprints.yml WARNING: Could not find an entry with coicopCode 11.1 in footprints.yml Found 11.2. Updating.. WARNING: Could not find an entry with coicopCode 12.1 in footprints.yml WARNING: Could not find an entry with coicopCode 12.2 in footprints.yml Found 13.1. Updating.. WARNING: Could not find an entry with coicopCode 13.2.1 in footprints.yml WARNING: Could not find an entry with coicopCode 13.2.9 in footprints.yml WARNING: Could not find an entry with coicopCode 13.3 in footprints.yml WARNING: Could not find an entry with coicopCode 13.9 in footprints.yml

Should these new categories be merged in a later PR? Some of them are required for our own carbon accounting.

corradio commented 4 years ago

For reference these are all the coicop categories for which we have a footprint, but for which we don't have a category in footprints.yml: WARNING: Could not find an entry with coicopCode 01 in footprints.yml ... WARNING: Could not find an entry with coicopCode 13.9 in footprints.yml

Should these new categories be merged in a later PR? Some of them are required for our own carbon accounting.

yup

martincollignon commented 4 years ago

@corradio we probably need to get a "global" model as AFAIK the country code is an optional value?

corradio commented 4 years ago

@corradio we probably need to get a "global" model as AFAIK the country code is an optional value?

Should we just take the average of all countries? Furthermore, I still need two concordance table entries FOOD AND NON-ALCOHOLIC BEVERAGES and CULTURAL SERVICES, as they both still are defined in footprint.yml and use the old ÅlandsIndex

martincollignon commented 4 years ago

Yes, I believe we should use the average of all countries (weighted).

electricitymaps / bloom-contrib

Exiobase model #370