search

electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

Fix flight model #397

Closed corradio closed 4 years ago

corradio commented 4 years ago

Flight model was failing due to incorrect argument position. Added a test to make sure this doesn't happen again!

Also fixed an error that happened with long-haul flights for which the airport wasn't in the load factor config. Please check carefully @pierresegonne !

corradio commented 4 years ago

I am not sure if I should simply comment or request changes.

It is the first time I am actually reviewing a PR for Tomorrow, so I wonder, is there anywhere where guidelines for reviews are described? I didn't find anything in notion and it could well fit into Technical: How we git gud (lol)

We unfortunately don't! It's probably a good idea to start such a doc (cc @madsnedergaard ) Also congrats on your first review !

madsnedergaard commented 4 years ago

I have a work-in-progress document and it’s something I’ll hopefully have time to continue with during slack week :)