electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
436 stars 104 forks source link

Ps/add displayname footprint #409

Closed pierresegonne closed 4 years ago

pierresegonne commented 4 years ago

Resolves the first part of https://github.com/tmrowco/tmrow/issues/2035

Problem

Some of the purchase keys are not very user friendly (upper case) so a new displayName property should be added for each entry.

Goal

Update thefootprints.yml file to add a displayName field which is more user friendly

pierresegonne commented 4 years ago

What should be done for entries such as Ice cream (Vanilla premium) ? What is between parenthesis would be suppressed altogether with the current form. In the case of ice cream it is a useful differentiator, so as for Water (bottled) vs Water (tap).

Should we make a manual list of what of (*) that should be deleted?

corradio commented 4 years ago

What should be done for entries such as Ice cream (Vanilla premium) ? What is between parenthesis would be suppressed altogether with the current form. In the case of ice cream it is a useful differentiator, so as for Water (bottled) vs Water (tap).

Should we make a manual list of what of (*) that should be deleted?

I'll let @martincollignon address that

pierresegonne commented 4 years ago

@martincollignon do you have any time to look into that? :)

martincollignon commented 4 years ago

Yes, very sorry. I'm wondering whether we should make children for these?

Icecream -Vanilla Icecream --Premium Vanilla Icecream

or something similar?

corradio commented 4 years ago

Jumping in here: just remember the implications of adding another layer in terms of display in the North app as we don't always display all levels.

On Thu, Jun 4, 2020 at 7:59 PM martincollignon notifications@github.com wrote:

Yes, very sorry. I'm wondering whether we should make children for these?

Icecream -Vanilla Icecream --Premium Vanilla Icecream

or something similar?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/tmrowco/northapp-contrib/pull/409#issuecomment-639012541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUIKERN4LPT7IIN4LPAF3RU7OGJANCNFSM4NQVZPUA .

--

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

pierresegonne commented 4 years ago

Ok I'll just go through the list then and note down all the (*) that seem relevant to remove and adapt the script so that only these are removed. It's a quick fix but should work fine if we don't update what's in the footprint file every 2nd day.

pierresegonne commented 4 years ago

@corradio @martincollignon should be good now. Only the parenthesis containing non useful information are removed, i.e (ND), (D), (S), (SD)