electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
436 stars 104 forks source link

Adds index.js to purchase integration folder to fix north compatibility #443

Closed dafrie closed 4 years ago

dafrie commented 4 years ago

North imports all modules (or better: *.js) found in each the integrations folders in contrib. Since the nag-categories.js file is no source in itself, this breaks North. Added a quickfix but not sure if this may break Bloom?

Alternatively we just fix it in North, i.e. ignore the Purchase integrations (since they are not active anyway...)

madsnedergaard commented 4 years ago

Think this is fine, did you test in the app? Then I'll fix it in Bloom when bumping contrib :)

dafrie commented 4 years ago

yep it works, i.e. at least doesn't crash the app on launch ;)