electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

Cleaning up #464

Closed corradio closed 3 years ago

corradio commented 3 years ago

FYI @pierresegonne

madsnedergaard commented 3 years ago

What was the reason for removing wildcard imports?

And have you ensured that the rename of this repository isn't messing anything up - like CirleCI for example? 🤔

madsnedergaard commented 3 years ago

Whoops sorry, misclicked -.-'

corradio commented 3 years ago

It was buggy (often it would require clearing cache for the imports to be re-updated)..

On Wed, Oct 14, 2020 at 9:12 AM Mads Nedergaard notifications@github.com wrote:

Whoops sorry, misclicked -.-'

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tmrowco/bloom-contrib/pull/464#issuecomment-708208923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUIKGKVNOC5LA62IWEH7DSKVFPBANCNFSM4SOR6CZQ .

--

Olivier Corradi

Founder, CEO

https://www.linkedin.com/in/oliviercorradi https://twitter.com/corradio

tmrow.com

corradio commented 3 years ago

And have you ensured that the rename of this repository isn't messing anything up - like CirleCI for example? 🤔

Seems like it is working!

madsnedergaard commented 3 years ago

Okay, let get this merged then :)