search

electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

COICOP categories for items #488

Closed pierresegonne closed 3 years ago

pierresegonne commented 3 years ago

Description

Proposal for resolving https://github.com/tmrowco/bloom/issues/337 by combining the two identified approaches.

Note:

Should we take that opportunity to also clean up the footprints.yml structure ? The top categories Entertainment and Stores which don't correspond to COICOP categories could for example be removed. This could enable us to have a footprints.yml where the entries actually follow the hierarchy of the COICOP categorisation.

skovhus commented 3 years ago

@pierresegonne Can you ping me once this is ready for review, maybe making it draft until ready? CI seems to fail. :)

pierresegonne commented 3 years ago

Sum up of the changes for the footprints.yml file:

  1. Got rid of the legacy North structure where items where regrouped under non-coicop related, synthetic parents (ex: Store)
  2. moved instead all items under the COICOP category in which they belong (ex Lenovo Thinkpad X270 under Information and communication equipment)
  3. attributed them an associatedPurchaseCategory which corresponds to the key of the closest parent that is a proper COICOP category
pierresegonne commented 3 years ago

Created this issue https://github.com/tmrowco/bloom-contrib/issues/499 to keep track of the improvements identified here that would nice to add but are not in the scope covered by this PR