search

electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

Supports multiplying by number of participants in meal model #495

Closed madsnedergaard closed 3 years ago

madsnedergaard commented 3 years ago

Issue

https://github.com/tmrowco/bloom/issues/338

Description

Updates Meal model to support multiplying the emission by number of meals/participants.

Changes

Preview

image

:warning: FYI/NOTE

I am not sure about best approach here with regards to name - I have here reused participants from transportation, but would it make more sense to have something like "numberOfMeals" instead? 🤔

I'm unsure if it's too weird that participants is multiplying emissions here, but dividing emissions in the transportation model.

madsnedergaard commented 3 years ago

I think numberOfMeals (mealCount?) is a better name. Participants is ambiguous, e.g. multiple people could share one meal.

Thanks, then "participants" stays transportation-specific and I will introduce a new numberOfMeals attribute :)