electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

energinet: support multiple meters #498

Closed skovhus closed 3 years ago

skovhus commented 3 years ago

https://github.com/tmrowco/bloom/issues/408

Support multiple smart energinet meters.

skovhus commented 3 years ago

Nice! If I understood correctly, this creates one activity per metering point.

Actually, the code sums all metering points to one activity. The code was already in place, it just didn't work as we only took the first meter.

See https://github.com/tmrowco/bloom-contrib/pull/498/files#diff-83b49b9a6481ae7b4c89895b7331aa298b5a43f4bf3dbd6ce8734fcdbbe41fd5R229, here we define how the end activity looks like if you have one or more smart meters. SAMPLE_MULTIPLE_ACTIVITY is probably a misleading name, as there is one activity but multiple smart meters.