search

electricitymaps / bloom-contrib

Making carbon footprint data available to everyone.
https://www.bloomclimate.com
MIT License
434 stars 104 forks source link

Fix erroneous purchase category definitions #500

Closed pierresegonne closed 3 years ago

pierresegonne commented 3 years ago

Description

The identified purchaseCategories correspond to identifiers that don't hold any emission factors. Therefore when bloom activities pointing to these purchaseCategories are created, they won't have any carbon footprint

Misc

For more context, see this issue

skovhus commented 3 years ago

@madsnedergaard FYI I found two other issues when adding unit tests for this. :)

madsnedergaard commented 3 years ago

FYI: We also need to migrate existing activities with incorrect identifier :)

skovhus commented 3 years ago

FYI: We also need to migrate existing activities with incorrect identifier :)

Yes, I believe this is covered in https://github.com/tmrowco/bloom/issues/292#issuecomment-748224152

madsnedergaard commented 3 years ago

FYI: We also need to migrate existing activities with incorrect identifier :)

Yes, I believe this is covered in tmrowco/bloom#292 (comment)

Ah, nice - I'll do that migration on prod-database now :)

EDIT Done!