search

electricitymaps / electricitymaps-contrib

A real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.55k stars 940 forks source link

Canary islands #1049

Closed strassburger closed 6 years ago

strassburger commented 6 years ago

Not very importand, but the locals see it different. The names of the Country -Spain- and the islands are not translated in different languages. Checked it in english, german and spanish Country: allways Spain The names of the Islands are allways in english also. One special: The locals want to see "El Hierro" and not Hierro only. They are absolutely right. Like La Palma that is absolutly correct. Sorry, i did not recognize earlier. My fault. Refernce to #1028

systemcatch commented 6 years ago

Hey @strassburger do you want provide a list of what the Islands should be named. Alternatively the translations are done in https://github.com/tmrowco/electricitymap/tree/master/web/locales which you can update.

strassburger commented 6 years ago

Hey @systemcatch, Take the first option, Do not think it is a really local problem.

Did look around: There is different handling of translating the names. The official touristic web side does not translate the island names at all. They keep the Island names in spanish. Only the Island group "Canary Islands" are translated in the different languages. But the Island group "Canary Island" is not used any more in EM. Source: https://www.hellocanaryislands.com/ Think that is the most convenient way to handle the island names.

So only two points are left:

systemcatch commented 6 years ago

Ok so in https://github.com/tmrowco/electricitymap/blob/master/web/locales/en.json (English translation) only Hierro needs to be changed to El Hierro, Spain will remain as Spain as that is the correct English translation.

We should update https://github.com/tmrowco/electricitymap/blob/master/web/locales/es.json (Spanish translation) to reflect the new split by islands. Also other locale files don't mention Canaries.

strassburger commented 6 years ago

@systemcatch both done. Thanks for the help and the trust.

strassburger commented 6 years ago

hope got it now, thanks again

corradio commented 6 years ago

Thanks for taking over here guys! I'll push to production asap.

On Wed, Jan 31, 2018 at 3:54 PM, strassburger notifications@github.com wrote:

hope got it now, thanks again

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tmrowco/electricitymap/issues/1049#issuecomment-361956302, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlEKO5a6aWY3Nt78C5eE98iMwG6Au7Hks5tQH6sgaJpZM4RyOdM .