electricitymaps / electricitymaps-contrib

A real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.57k stars 943 forks source link

relax restrictions on Austria #1313

Closed jarek closed 6 years ago

jarek commented 6 years ago

from Kibana: invalid point: {'zoneKey': 'AT', 'datetime': datetime.datetime(2018, 4, 8, 17, 45, tzinfo=tzutc()), 'production': {'biomass': None, 'coal': None, 'gas': None, 'hydro': None, 'nuclear': None, 'oil': None, 'solar': 55.0, 'wind': 2255.0, 'geothermal': None, 'unknown': None}, 'storage': {'hydro': None}, 'source': 'entsoe.eu', 'schemaVersion': 1}, reason:Coal or oil or unknown production value is required for AT

We should probably add gas and maybe biomass to the list of "one of required" sources.

Current data: at

Note that the current data is only accepted by the validator because of tiny 22 MW worth of "unknown" production. If that drops off, we'll be dropping the entire datapoint. However, considering the last 24 hours of history, it seems likely that coal and oil being 0 MW right now is valid: at_history

systemcatch commented 6 years ago

The error message is out of step with what is actually checked, https://github.com/tmrowco/electricitymap/blob/master/parsers/lib/quality.py#L63 tries gas as well. That datapoint is missing hydro as well so it's probably a bad one.

corradio commented 6 years ago

@systemcatch @jarek anything we should change here? Feel free to update validation conditions on the ENTSOE parser or in quality.py. Else, let's close the issue

systemcatch commented 6 years ago

@corradio yes can you update https://github.com/tmrowco/electricitymap/blob/master/parsers/lib/quality.py#L66 to the following so the error message is correct.

"Coal, oil, gas or unknown production value is required for"