search

electricitymaps / electricitymaps-contrib

The open source repository for Electricity Maps App and data parser that enables a real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.59k stars 947 forks source link

Incorrect axis labels in emissions chart (production mode) #5140

Closed tonypls closed 1 year ago

tonypls commented 1 year ago

Describe the bug When using the emissions chart in production mode the y axis changes to an incorrect scale

To Reproduce Steps to reproduce the behaviour:

  1. Go to the app
  2. Select production mode
  3. Open the country panel
  4. Select carbon emissions
  5. The carbon emissions chart will have incorrect labels for the Y axis

Expected behavior The axis labels match the data

Screenshots

image
mrSeoD commented 1 year ago

I could look into this!

VIKTORVAV99 commented 1 year ago

I could look into this!

Sure thing! I'll assign the issue to you.

Thanks for taking a look at it!

mrSeoD commented 1 year ago

My apologies for a delayed look into this, but I wanted to ask about another bug that I ran into as I was looking into this issue. I was able to find a place where I could scale the y-axis, but I noticed another bug: image

As you can see from the screenshot above, I clicked South Central Sweden, which has a correct intensity of 28g, but the panel on the left shows 696g. And this is the case for every single country. No matter what country I press, the carbon intensity on the left panel is always set to 696g and the graph that needs to be fixed for this issue has the same values as well.

I checked the official website, and it doesn't have this problem. But this only happens within the mockserver. Do you have an idea why this may be happening?

VIKTORVAV99 commented 1 year ago

My apologies for a delayed look into this, but I wanted to ask about another bug that I ran into as I was looking into this issue. I was able to find a place where I could scale the y-axis, but I noticed another bug: image

As you can see from the screenshot above, I clicked South Central Sweden, which has a correct intensity of 28g, but the panel on the left shows 696g. And this is the case for every single country. No matter what country I press, the carbon intensity on the left panel is always set to 696g and the graph that needs to be fixed for this issue has the same values as well.

I checked the official website, and it doesn't have this problem. But this only happens within the mockserver. Do you have an idea why this may be happening?

The reason for this is quite simple, we have only added mock data for two zones, DE and DK-DK2 and every other zone will fall back to DE data. As for the tool tips they get their data from the global state file. A file that contains a lot less information about each zone but has the basics. Like the carbon intensity.

mrSeoD commented 1 year ago

Thanks for the clarification! I was able to fix the error and made a pull request. I would appreciate it if you could look into it and please let me know if you have any questions!

mrSeoD commented 1 year ago

Just wanted to follow up! Thanks!

madsnedergaard commented 1 year ago

Thanks for working on this! We should probably also change the mockserver to not fallback to DE, but just return "no data" for zones we don't have mock data for :)

VIKTORVAV99 commented 1 year ago

Thanks for working on this! We should probably also change the mockserver to not fallback to DE, but just return "no data" for zones we don't have mock data for :)

Perhaps we could do this in combination with you backend PR so there are a way to test the states locally without the app backend as well?