electricitymaps / electricitymaps-contrib

The open source repository for Electricity Maps App and data parsers that enables a real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.6k stars 946 forks source link

cross-border arrows do not zoom in #6580

Open bernieEV opened 7 months ago

bernieEV commented 7 months ago

1) start the URL https://app.electricitymaps.com/map 2) klick on country AUSTRIA 3) the map zoomed in, but the "cross-border arrow overlay" did not zoom in.

VIKTORVAV99 commented 7 months ago

Hi!

I can't seem to replicate the issue.

Could you provide some more information such as which browser or platform you are using the app on?

phiphou commented 7 months ago

I have the same problem.

When I click on a zone, map zooms to the selected zone but arrows are not "synchronized".

If I move the map with arrow keys, arrows are still not updated.

But when I move the map with mouse, as soon I release the mouse, arrows updates and are now well placed.

I'm on Windows 11 and Chrome 123. I also encounter the same problem with Firefox 124 and Edge 123.

FireShot Capture 027 - Electricity Maps - Émissions CO₂ de la consommation électrique en tem_ - app electricitymaps com

VIKTORVAV99 commented 7 months ago

I just made some changes related to the arrows (released today), any indication it made things better?

I will also be making further changes to some internal logic that might affect this.

phiphou commented 7 months ago

My tests have been made with the today's new version.

VIKTORVAV99 commented 7 months ago

My tests have been made with the today's new version.

Thanks for getting back to me, will see what I can do about it.

bernieEV commented 7 months ago
Hi Viktor,

  with the latest firefox on GNU/Linux

  1) pointing into AUSTRIA and clicking the left mouse button brings
  the table on the left side
     and the map is zoomed, but the border-arrows do not follow.

  2) just moving the scroll wheel one tick (zoom) is fixing the map
  and the border-arrows are correct.

  best regards
  Bernhard

On 09.04.24 21:52, Viktor Andersson
  wrote:

    My tests have been made with the today's new
      version.

  Thanks for getting back to me, will see what I can
    do about it.
  —
    Reply to this email directly, view it on GitHub, or unsubscribe.
    You are receiving this because you authored the thread.Message
      ID: ***@***.***>
  [

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/electricitymaps/electricitymaps-contrib/issues/6580#issuecomment-2045946655", "url": "https://github.com/electricitymaps/electricitymaps-contrib/issues/6580#issuecomment-2045946655", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

phiphou commented 6 months ago

Any news about this quite anoying bug ?

VIKTORVAV99 commented 6 months ago

Any news about this quite anoying bug ?

Yeah we are planning on fixing it but there are some underlying fixes in #6651 we want to get merged first.

phiphou commented 2 weeks ago

6651 has been merged, time to fix this ;) 💪