electricitymaps / electricitymaps-contrib

A real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.37k stars 911 forks source link

Separate the disputed area of Western Sahara #6618

Open madsnedergaard opened 3 months ago

madsnedergaard commented 3 months ago

Description

We currently show the Moroccan-controlled area of Western Sahara as part of Morocco. Since the actual ownership of this areas is disputed and unclear, it would make sense to merge the area into a full Western Sahara zone.

See our guide on how to edit the geometries if you want to pick this up :)

Screenshot 2024-04-03 at 09 37 47

More details on the conflict:

How Google Maps shows the area:

Screenshot 2024-04-03 at 09 37 03

ryanguomd commented 2 months ago

Hi, I would like to work on this!

VIKTORVAV99 commented 2 months ago

Hi, I would like to work on this!

Hi and thanks!

I'll assign you the issue.

ryanguomd commented 2 months ago

I'm getting a yarn install error when I try to run yarn && yarn update-world in the 'web' folder. Screenshot 2024-04-15 at 4 47 21 PM

VIKTORVAV99 commented 2 months ago

I'm getting a yarn install error when I try to run yarn && yarn update-world in the 'web' folder.

Screenshot 2024-04-15 at 4 47 21 PM

Ah it appears this wiki page has slipped us by. We shifted to using PNPM a while back so it should work with that instead.

Double check your node version as well, we have not tested that any packages work on node 21 as we only increment LTS versions (even version numbers).

ryanguomd commented 2 months ago

Double check your node version as well, we have not tested that any packages work on node 21 as we only increment LTS versions (even version numbers).

Thanks, I'm using node v20 now. I changed the borders in an untitled project on QGIS, but I'm a bit confused on how I can see if I'm actually directly editing the world.geojson file. Also, running pnpm generate-world gives this error:

Screenshot 2024-04-15 at 8 03 42 PM

Couldn't find much from debugging so far.