search

electricitymaps / electricitymaps-contrib

A real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.38k stars 909 forks source link

[Frontend] Welcome modal doesn't resize vertically with screen #6731

Open s-egge opened 2 months ago

s-egge commented 2 months ago

Describe the bug The Welcome modal that is displayed when entering the website for the first time does not scale vertically based on the screen size or allow scrolling down to see the whole modal.

To Reproduce Steps to reproduce the behavior:

  1. Open a private browser (or clear history for https://app.electricitymaps.com/map)
  2. Go to https://app.electricitymaps.com/map
  3. Make browser window smaller vertically
  4. See error

Expected behavior I expected the Welcome modal to either resize or the page to allow me to scroll so that the rest of the modal would come into view.

Screenshots image

Desktop (if relevant):

PmplCode commented 3 weeks ago

I agree with the expected behavior, I reckon it should allow scrolling.

VIKTORVAV99 commented 3 weeks ago

I agree with the expected behavior, I reckon it should allow scrolling.

I believe we would prefer if it was centred and shrunken to fit the screen size rather than scrolling (within reasonable limits).