search

electricitymaps / electricitymaps-contrib

The open source repository for Electricity Maps App and data parsers that enables a real-time visualisation of the CO2 emissions of electricity consumption
https://app.electricitymaps.com
GNU Affero General Public License v3.0
3.61k stars 946 forks source link

"Installed capacity" label is shown for aggregated data #7320

Open corradio opened 1 month ago

corradio commented 1 month ago

Describe the bug "Installed capacity" label should not be shown for aggregated data

To Reproduce Steps to reproduce the behavior:

  1. Pick any zone
  2. Select Yearly view

Expected behavior "Installed capacity" label should not be shown for aggregated data.

Screenshots

image
VIKTORVAV99 commented 1 month ago

Let's see if someone want to fix this as a part of Hacktoberfest otherwise I'll pick it up. 👍🏼

Reterics commented 1 month ago

I am happy to work on it as part of Hacktoberfest, if it is still available

Should the label removal apply for daily, monthly, and yearly? (except the hourly, because it has the relevant data => capacitySources)

https://github.com/electricitymaps/electricitymaps-contrib/blob/c2796b5d8fb35741c112e2ad6d6f593796a2897b/web/src/features/charts/bar-breakdown/BarBreakdownChart.tsx#L143

Nivedhitha-dp commented 1 week ago

I am interesting in picking up this issue, can this be assigned to me.

VIKTORVAV99 commented 1 week ago

I am interesting in picking up this issue, can this be assigned to me.

Sure thing, please try and do it in a way that don't cause CLS when shifting between the aggregations.