search

electrickite / geotv

Geographic location template variable for MODX Revolution
GNU General Public License v2.0
1 stars 5 forks source link

Suggestion : add OpenStreeMap as map engine #4

Open Spheerys opened 8 years ago

Spheerys commented 8 years ago

I'm a contributor to OSM mapping and I prefer to use OSM for mapping activities : it's generaly more precise, and I don't like Google anymore :) Maybe it's a big deal to implement OSM on GeoTV, but if it's not, that's my suggestion for a future release : make an option during GeoTV installation or on a system key to choose which mapper we want :)

electrickite commented 8 years ago

I don't have any fundamental problems using OSM. I'm personally not as experienced with their API, so Google is my go-to choice. Does OSM provide the same drawing features (polygons, etc) as the Google Maps API?

Spheerys commented 8 years ago

I think yes, but I'm not an expert with the OSM API. In fact, I can also ask a friend to have a look on this point :)

electrickite commented 8 years ago

If OSM were implemented as a mapping provider, Google Maps should remain available as an option. Some locations have better coverage through Google. It's also my understanding that in some countries (notably China) using crowd-sourced mapping data like OSM is illegal.

Spheerys commented 8 years ago

Yes of course : we plan to try to implement OSM on GeoTV as an option next weeks. At minimum a working principe. In my aera, GMaps is very poor and I also do my best to avoid using Google tools :)

I think an option on TV parameters to choose between GMaps and OSM very nice.

Spheerys commented 8 years ago

What is the best way to develop the OSM support ? We make another branch on our cloned repository and we replace the GMaps API calls ?

electrickite commented 8 years ago

Yes, working on a separate feature branch would be a good idea.

The best approach might be to re-write the point and area drawing interface using something like Leaflet.js. Then use OSM or Google to provide the tile sets.

Something similar to this: https://github.com/shramov/leaflet-plugins/blob/master/examples/google.html

RichardHitier commented 8 years ago

Hi, I'm currently working on the OSM rewriting. But I 'm still stuck on one point: allowMultiple is always set to 1 even if i set it to 'No' in the "input option" page. any clue appreciated :-)

thanks.

Spheerys commented 8 years ago

A little up because we are blocked with Richard. But maybe we have to open a new issue for this specific problem ?

Spheerys commented 6 years ago

A pull request is on the way :)

Spheerys commented 6 years ago

Here it is : https://github.com/electrickite/geotv/pull/18 Thanks Richard !!

Once merged and upgraded on MODX, you have to change the key setting geotv.enable_osm to enable. You can still use GMaps by setting it to disabled.

Spheerys commented 5 years ago

Hello @electrickite :)

Can you please take a look to our job, and evently ask question or say something about the OSM option ?