electrikhq / electrik

Electrik is a full-featured, open-source, starter-kit to help you build you your SaaS application.
https://electrik.dev
MIT License
265 stars 22 forks source link

great but there are some issues #12

Closed idealerror closed 1 year ago

idealerror commented 1 year ago

Hello,

This is a great starter for building a SaaS with Laravel, however I've found some issues:

This is all I found on the first pass, but it's a start :)

neerajsohal commented 1 year ago

Hey @idealerror,

Thanks a lot for testing and finding issues. I really wanted someone to do this as I have contracted "feature blindness" :)

These issues are a good start for a production release prep. Although, there is another issue already listed for Tax support. It's a little tricky to make it dynamic. Some intervention would be required from the developer's end. I will add this to the documentation as well.

yordadev commented 1 year ago

great feedback @idealerror .

There are a lot of hardcoded mentions of India vs. US for subscriptions This is a good call out, and I agree I don't think it scales well either.

I am happy to see @neerajsohal address your feedback and get issues on the books. This starter definitely has a-lot of potential.

neerajsohal commented 1 year ago

@idealerror

Sorry, it took quite some time to close this issue. I got busy with another project and some of these needed code rewrites.

Have checked and closed all the items listed in the issue.

Again thanks a lot for taking the time out and helping me with the feedback. I greatly appreciate it.