search

electro-smith / DaisyDuino

Arduino Support for the Daisy Audio Platform.
https://www.electro-smith.com/daisy
MIT License
92 stars 20 forks source link

Stmduino control bugfix #31

Closed beserge closed 3 years ago

beserge commented 3 years ago

Fixes #30

Tested a bit on the patch, works great, Needs to be tested on the rest of our hardware. Also: need to go through and confirm none of the example sketches have hardcoded analog reads hanging around.

beserge commented 3 years ago

Fix daisyduino controls broken by stm32duino update

stephenhensley commented 3 years ago

This and #29 seem solid

tested the field, and everything seems to be working as expected. Still wanna check on the pod/petal before merging and making a release, but you can go ahead and update the library.properties file to have v1.4.0 for when we publish it.

stephenhensley commented 3 years ago

So Pod, Field, Petal all check out from a control point of view, but I'm getting some serious performance issues on anything that uses the SDRAM, which makes me think either the MPU, or the Cache aren't getting initialized/enabled correctly.

Would be worth looking through the changes here and in the stm32duino changes to see if anything's too different that could be causing this. (Also probably worth checking if it's unique to the Pedal or not, because that's the only board I noticed it on).

stephenhensley commented 3 years ago

good catch on the extra bugs!

Think this is good to go. Tested a few other examples to make sure, but everything seems solid.