electro-smith / DaisyDuino

Arduino Support for the Daisy Audio Platform.

MIT License

92 stars 20 forks source link

Upgrade DaisySP to newest version #47

Closed chmanie closed 2 years ago

chmanie commented 2 years ago

I took the liberty of upgrading DaisySP to the newest version. As there is no clear version and this was just copied over, I can't really be sure.

For the next person doing this tedious task, the DaisySP commit DaisyDuino is based on now is 4263388.

This adds support for the new FIR, Looper and Phaser classes as well as some new utility functions like fmap.

stephenhensley commented 2 years ago

@chmanie thanks for the contribution!

We'll take look over the changes, and get this merged in!

Good point about the versioning of the C++ DaisySP. The plan is to implement a sem-ver based versioning system similar to what's used in the libDaisy library, but we haven't gotten around to it quite yet.

chmanie commented 2 years ago

Sorry for the weird diff, I don't really know what happened here. Could this be a tabs vs. space problem?

stephenhensley commented 2 years ago

No worries, it's not too many files.

Looks like spaces were preserved. Could be line endings or something?

beserge commented 2 years ago

Changes

If you could add the new classes to keywords.txt so they syntax highlight correctly that would be great.

Once that's complete, I say it's ready to merge! Thanks for your contribution! 🎆

Test Procedure

All tests were performed on the Daisy Patch, with a rev4 seed.

Flashed some of the examples that were touched with just line endings and so on. seed/adsr, seed/bitcrush, seed/decimator.

Made a small example with each of the new modules (FIR, Looper, Phaser) and passed some audio through them.

chmanie commented 2 years ago

@beserge Thank you so much for the thorough review. I added the relevant keywords and fixed some ordering/naming issues on the way.