electro-smith / DaisyExamples

Examples for the Daisy Platform
https://github.com/electro-smith/DaisyWiki/wiki
MIT License
372 stars 193 forks source link

Update examples to built in board MidiHandlers #196

Closed beserge closed 3 years ago

beserge commented 3 years ago

Added a MidiHandler and Init to each breakout board (among other things) here. This PR will update the three relevant examples to use those new handlers.

stephenhensley commented 3 years ago

this works, and fixes some issues that exist in the current implementation (i.e. Clock messages stalling the state machine, etc.).

I do want to add unit tests to validate the parser functionality before we make further changes, or rework any of the MidiEvent stuff, but I don't want to leave MIDI partially broken in the meantime. So I think for now this is good to go.