search

electro-smith / DaisyExamples

Examples for the Daisy Platform
https://github.com/electro-smith/DaisyWiki/wiki
MIT License
372 stars 193 forks source link

libDaisy submodule capitalization #220

Open CorvusPrudens opened 2 years ago

CorvusPrudens commented 2 years ago

The libDaisy capitalization is inconsistent across the tools in DaisyExamples. The submodule is set to always clone into libdaisy, and some of the helper.py commands create lower case libDaisy references. Since the repo name is libDaisy, it's probably best to get everything aligned with that capitalization.

This was particularly annoying for mac / linux users because the unix cpp configuration for vscode assumed a capital D.

stephenhensley commented 2 years ago

this should be resolved, but I know people may still run into an issue with previous clones (though at this point, even with wrong spelling it compiles on the mac OS machine I was testing on ... So we'll see I suppose).

I'll leave this open for a bit with this note:

If you get a can't find libDaisy related error -- you can either manually rename the "libdaisy" folder to "libDaisy", or reclone the repo to resolve the issue.

MrBlueXav commented 2 years ago

Hello, I'm on a linux platform. It's a problem when using helper.py for creating a new project. The makefile won't work as it refers to "libdaisy" instead of libDaisy. Easy to fix, though.