electro-smith / DaisyExamples

Examples for the Daisy Platform
https://github.com/electro-smith/DaisyWiki/wiki
MIT License
372 stars 193 forks source link

Add sampler example for daisy field #228

Closed ajvirgona closed 2 years ago

ajvirgona commented 2 years ago

Adding an example for the daisy field, a very simple sampler with 8 sample slots and dedicated record and play buttons for each. See README.md for more detail.

I'm new to the daisy ecosystem so I'd appreciate someone reviewing my code. This is also my first open source contribution.

Writing this simple example helped me learn the basics of programming for daisy and taught me how and why to use SDRAM. Hopefully another beginner will find it a helpful reference.

I haven't generated all the project files which other examples seem to have because i'm not sure how and I assume someone at electrosmith has a process for this. If you can point me in the right direction i'm happy to do it.

stephenhensley commented 2 years ago

Thanks for the contribution! Looks like a fun example.

We'll review it over the next week or so, and get it merged in!

ajvirgona commented 2 years ago

Thanks Stephen!

beserge commented 2 years ago

Super awesome! The only thing I'd want to change is to have the keyboard buttons light up when you hold them. Otherwise I say we merge this ASAP! 👍

stephenhensley commented 2 years ago

Since it was working, we'll add it. If we want to add the LED/button state we can do that in a later PR.