search

electro-smith / DaisyExamples

Examples for the Daisy Platform
https://github.com/electro-smith/DaisyWiki/wiki
MIT License
361 stars 189 forks source link

rebuild_all.sh crashes on Linux #256

Closed znmeb closed 2 years ago

znmeb commented 2 years ago

./rebuild_all.sh crashes after building the libraries:

❯ ./rebuild_all.sh
building libDaisy . . .
arm-none-eabi-ar: creating build/libdaisy.a
done.
building DaisySP . . .
done.
./rebuild_all.sh: line 4: ./ci/build_examples.py: Permission denied
finished

The problem is that the script ci/build_examples.py needs to be executable.

stephenhensley commented 2 years ago

oh interesting -- I had thought I resolved this already (because CI had the same issue). Are you on the most recent commit, or are you possibly a few commits behind?

If you have the permissions you can do chmod +x ci/build_examples.py.

znmeb commented 2 years ago

I forked the whole repo right after I filed this issue, so I'm pretty sure I have the latest commit.

stephenhensley commented 2 years ago

@znmeb good to know. I may have been thinking of libDaisy (we added a similar script there just before the holidays.

The DaisyExamples CI actually invokes python to call the script: python ./ci/build_examples.py so it wouldn't have caught this issue.

I'll merge a fix here in a few.

znmeb commented 2 years ago

You have to be careful with using python like that. The system Python may be Python 2 or Python 3 and the user may be running in a virtual environment that has silently changed PATH.