search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
866 stars 138 forks source link

Verb memory fix #11

Closed stephenhensley closed 4 years ago

stephenhensley commented 4 years ago

MAX Delay size was set to 32kB, but was never checked with any settings.

Added a check to return 1 if it exceeds expected memory, and updated documentation.

csounder commented 4 years ago

Great fix.

Don't you think it would be nice if you told everyone that this was all based on Csound code - like your adaptation of this reverbsc opcode in Csound?

Dr. Richard Boulanger Professor Electronic Production and Design Berklee College of Music

On May 15, 2020, at 6:30 PM, Stephen Hensley notifications@github.com wrote:

 MAX Delay size was set to 32kB, but was never checked with any settings.

Added a check to return 1 if it exceeds expected memory, and updated documentation.

You can view, comment on, or merge this pull request online at:

https://github.com/electro-smith/DaisySP/pull/11

Commit Summary

fixed pretty big memory issue with reverbsc module reformatted files and removed commented out redundant code. added check for memory usage, and updated documentation. File Changes

M doc/daisysp_reference.pdf (0) M doc/style_guide.pdf (0) M modules/reverbsc.cpp (547) M modules/reverbsc.h (169) Patch Links:

https://github.com/electro-smith/DaisySP/pull/11.patch https://github.com/electro-smith/DaisySP/pull/11.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

csounder commented 4 years ago

Awesome!!! I do see that, in the code you do state that it was ported from Csound and that you list the original authors of the algorithms under the hood! Wonderful. It is especially inspiring to my Csound students and to the international Csound community of users and developers!!!

Dr. Richard Boulanger Professor Electronic Production and Design Berklee College of Music

On May 15, 2020, at 7:09 PM, Dr. Richard Boulanger rboulanger@berklee.edu wrote:

Great fix.

Don't you think it would be nice if you told everyone that this was all based on Csound code - like your adaptation of this reverbsc opcode in Csound?

Dr. Richard Boulanger Professor Electronic Production and Design Berklee College of Music

On May 15, 2020, at 6:30 PM, Stephen Hensley notifications@github.com wrote:

 MAX Delay size was set to 32kB, but was never checked with any settings.

Added a check to return 1 if it exceeds expected memory, and updated documentation.

You can view, comment on, or merge this pull request online at:

https://github.com/electro-smith/DaisySP/pull/11

Commit Summary

fixed pretty big memory issue with reverbsc module reformatted files and removed commented out redundant code. added check for memory usage, and updated documentation. File Changes

M doc/daisysp_reference.pdf (0) M doc/style_guide.pdf (0) M modules/reverbsc.cpp (547) M modules/reverbsc.h (169) Patch Links:

https://github.com/electro-smith/DaisySP/pull/11.patch https://github.com/electro-smith/DaisySP/pull/11.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

stephenhensley commented 4 years ago

@csounder

Yes, each module has the source of the original source code and any contributors listed in the Credits section of the header file.

This all gets parsed out to the daisysp_reference.pdf documentation that can be found in the doc/ folder

stephenhensley commented 4 years ago

@csounder Actually, good catch. This one has the original credits in the implementation which won't get processed into the documentation. I'll fix this shortly so the reference material gives proper credit!

csounder commented 4 years ago

You are doing awesome and important work Stephen! Can't wait to use, share, and teach with it!

Dr. Richard Boulanger Professor Electronic Production and Design Berklee College of Music

On May 15, 2020, at 9:10 PM, Stephen Hensley notifications@github.com wrote:

 @csounder

Yes, each module has the source of the original source code and any contributors listed in the Credits section of the header file.

This all gets parsed out to the daisysp_reference.pdf documentation that can be found in the doc/ folder

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

stephenhensley commented 4 years ago

@csounder

Thanks Dr. B! I appreciate the kind words.

I'd love to catch up soon; it's been a long time! I'll send you an email sometime this weekend.

csounder commented 4 years ago

Stephen,

That would be awesome.

Dr. Richard Boulanger Professor Electronic Production and Design Berklee College of Music

On May 15, 2020, at 9:38 PM, Stephen Hensley notifications@github.com wrote:

 @csounder

Thanks Dr. B! I appreciate the kind words.

I'd love to catch up soon; it's been a long time! I'll send you an email sometime this weekend.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.