electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
839 stars 132 forks source link

Shaper oscillators emit DC #150

Open madskjeldgaard opened 3 years ago

madskjeldgaard commented 3 years ago

Hello

Something I just noticed when using DaisySP in my SuperCollider plugins is that some of the shaper oscillators (ZOsc, VarShape and varSaw) emit DC and it is necessary to use a dc blocker in between their outputs and the system output at the moment. For ZOsc and VarShape it depends on the "shape" parameter it seems how much dc is in there.

ThankS!

madskjeldgaard commented 3 years ago

These are the affected oscillators :

sdiedrichsen commented 3 years ago

I think, that behaves correctly. E.g. take a classic Pulse oscillator with PWM. Only at 50% it's free of DC, at any other pulse width, it has a DC offset. But I never saw an analog implementation removing it by a feedforward of the PW voltage to the oscillator. So, inserting a high pass filter is an requirement.