search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
836 stars 131 forks source link

[CMake] Added missing files of phaser effect. #155

Closed COx2 closed 3 years ago

COx2 commented 3 years ago

Hello, DaisySP team.

When I was developing my application, I found a problem that could not resolve a reference of daisysp::Phaser functions. The reason for this is that adding the Phaser source code in CMake is forgotten.

Please check it.

stephenhensley commented 3 years ago

Good catch! Thanks for adding it!

I believe this may conflict with #153 since it restructures the CMake file a bit.

I'll try to get that one merged later today to see if anything will need to change here.

Thanks again!

stephenhensley commented 3 years ago

Alright, I merged the other PR and there was a conflict. I was able to resolve it (by pushing to your master branch).

Thanks for the PR! We appreciate the contribution!

COx2 commented 3 years ago

Thank you for your accepting. I have high hopes for this project.

BTW, I have created a project that showing an example of integration of DaisySP and JUCE6 with CMake. Hope this helps the newbies. https://github.com/COx2/juce_meets_DaisySP

stephenhensley commented 3 years ago

@COx2 oh very cool! I'll have to try it out this weekend or something! I actually have a very similar (though less featured) project set up with DaisySP/JUCE/CMake. Definitely excited to see what you do with it!

COx2 commented 3 years ago

Good stuff!!