Open fhoenig opened 1 year ago
Hi Florian,
The ADSR is ported from here (https://paulbatchelor.github.io/res/soundpipe/docs/adsr.html). Here's a note about it on that page:
NOTE: The attack, decay, and release parameters are "fuzzy" values that don't exactly correspond to duration in seconds. More accurately, they are special tau constant units that feed into the filter used to generate the envelope. The attack value specificly undergoes some "creative" modificiations in order to create snappier attack times. It is highly recommend to tune parameters by ear rather than to read the values literally.
For more reference: https://ccrma.stanford.edu/~jos/mdft/Exponentials.html https://ccrma.stanford.edu/~jos/mdft/Audio_Decay_Time_T60.html
We could clarify all of this in a documentation, comments in the example code, and etc. Thank you for bringing this topic up. We can look into this more and have a discussion.
Looks like
attack
is in seconds butdecay
andrelease
are off by a factor of ~5 w.r.t. them being seconds. Is this a know issue / intended?