Closed ndonald2 closed 5 months ago
This is awesome! We'll get this reviewed and merged within the next week!
Thanks for the contribution, @ndonald2 !!
Sounds great! Tested the module with your example code, tried a bunch of different settings. Did a quick code review as well, looks great!
Nice work! Thanks as always for the well documented PR and the phenomenal code. 🚀
Description
Adds a new, MIT-licensed ladder filter implementation with additional features and stability compared to the previous DaisySP moogladder (now in LGPL modules).
This implementation is ported from MIT-licensed code in the Teensy Audio Library, with the implementation derived from work in this paper from Computer Music Journal by Välimäki and Huovilainen.
This version brings the following advantages:
However it is a little bit more computationally expensive without additional optimizations not included here (block-based processing helps a bit). Still plenty fast enough to run multiple instances on a Seed.
I believe the OSS license stuff is all in order (preserved MIT license in header with original copyright, added copyright for modifications, and documentation of modifications).
Testing
I've used this code extensively in my own projects
Demos / Example Code
I don't have any audio or video demos handy but I could make some on request.
Example program