search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
891 stars 140 forks source link

Consider -Werror #33

Closed TheSlowGrowth closed 4 years ago

TheSlowGrowth commented 4 years ago

Being a relatively new code base, we could think about including -Werror in the compiler options. This would help a lot to keep the compilation output clean and also help find bugs quickly.

stephenhensley commented 4 years ago

Yeah, I agree. I personally hate letting warnings slip through.

I think I originally had a shared makefile for this and the libdaisy repo, and didn't know about -Wno-error=<warning> for some of the stm32 HAL warnings that we won't be fixing.

But for this repo -Werror would be preferred.