search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
891 stars 140 forks source link

Made docs deployment conditional #42

Closed TheSlowGrowth closed 4 years ago

TheSlowGrowth commented 4 years ago

This helps developers to use Travis CI when working on their forks. Without this, builds will fail on forks because deployment of the docs is not possible.

For electro-smith/DaisySP enable deployment by setting up DEPLOY_DOCS=1 in Travis CI.

stephenhensley commented 4 years ago

oh nice. Good catch. I'll set that up that variable in a bit.

Is the conditional 'equal to' really = and not == in Travis yml? If so, what a weird choice on their part.

TheSlowGrowth commented 4 years ago

I copied this from the Travis documentation and it works... But you're right, its weird. I looked it up: Its bash syntax, so = and == are aliases, but only if there are spaces around =.

But I agree that == is much clearer so I changed it. Good catch!

stephenhensley commented 4 years ago

Interesting, not sure I ever realized that was valid in bash either haha.

I just set up the env variable for master only. So should be good to go.