search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
866 stars 138 forks source link

AdEnv - Changing Attack/Decay time during stages can cause envelope to exceed its given range. #50

Closed stephenhensley closed 4 years ago

stephenhensley commented 4 years ago

With knobs mapped to attack/decay respectively, changing one quickly will some times cause the envelope to go much higher than the values set.

I haven't checked to see if it happens when curve is set to 0 (linear), but worth investigating.

Temporary band-aid, change attack/decay times on re-trigger of the envelope instead of at a constant rate.

beserge commented 4 years ago

Fix pending via #54

beserge commented 4 years ago

fixed via #54

stephenhensley commented 4 years ago

closing as fixed, and I didn't have any issues with the Patch Envelope example