search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
848 stars 134 forks source link

Change examples to not require input signal to demonstrate functionality #60

Closed andrewikenberry closed 4 years ago

andrewikenberry commented 4 years ago

Affected modules:

beserge commented 4 years ago

Pitchshift and reverb fixed via #61. examples/delayline is generated internally, perhaps stereodelay is only in DaisyExamples?

beserge commented 4 years ago

Additionally, once these changes are okayed, they should probably be carried throughout the programmer, daisyexamples, arduino, etc.

makingsoundmachines commented 4 years ago

maybe even keep both and rename the examples with external in pitchshifter_ext-input .. because it's the next thing people are going to code back in and it never hurts to have too many proven examples

stephenhensley commented 4 years ago

@makingsoundmachines I like this idea. I just merged the PR that removed those examples, but time permitting we'll start adding additional examples that do use audio input as well.

This was initially brought up after a discussion of making sure that each module in DaisySP could be tested with a Daisy Seed and a single Jack wired up, without having to get find an input source or any thing extra to be able to hear what the module does.

That said, having examples of many of these things that have audio input would be beneficial for a number of reasons. I'll open a new general issue for adding some examples that do show Audio Input as well.

stephenhensley commented 4 years ago

Also, closing because the two examples that didn't have output-only examples have been updated.