search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
848 stars 134 forks source link

host compilation, triangle polyblep fix #75

Closed zeroisnan closed 3 years ago

zeroisnan commented 3 years ago

This is a pull request that resolves #74 ( Enable compilation on native host )

zeroisnan commented 3 years ago

This also resolves #56

stephenhensley commented 3 years ago

Awesome! And good catch on the triangle wave.

Fwiw, there are float PI macros in the dsp.h file, but there are still a lot of earlier modules that still use the math.h versions. So I see why you added one to phasor.

Also, just noticed that the oscillator.h uses PI, but does not include math.h -- since dsp.h does include math.h, and daisysp.h includes both if you're using the entire library there would likely be no issues, but if you tried to import only oscillator, it may fail complilation.

I'll open specific issues for that stuff, but otherwise good stuff. And I'm excited to try out prototyping some dsp via VCV on a real computer for once! 😄

Thanks for the contribution and the info in #74