search

electro-smith / DaisySP

A Powerful DSP Library in C++
https://www.electro-smith.com/daisy
Other
866 stars 138 forks source link

Updating line-ending settings to play nicer across platforms #8

Closed jrepp closed 4 years ago

jrepp commented 4 years ago

I've noticed a lot of line-ending issues reviewing diffs and working in the repo. Here's a proposal that keeps the forces the windows EOL on VisualStudio files and opts for automatic line endings on everything else. If there is a specific reason the line endings handling was not the default lmk.

Here's a helpful link I found, it also covers how to clean up your line endings automatically in your repo:

https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings

Screen Shot 2020-03-31 at 12 13 18 AM
stephenhensley commented 4 years ago

@jrepp nice!

I don't remember the exact reasoning as to why we didn't have this, but I think at some point I had some stuff configured differently, and we had a few accidental 'rewrite every file in the repo' commits due to auto conversion issues (possibly on unusual extension files).

This looks like it should be fine, though!