stephenhensley
commented
3 years ago Looks great!
Minor things that I think would improve it:
- [x] Code Example link could link to DaisyExamples instead of just down to the photo of code.
- [x] Consider updating the "Features" section with modules that already exist, and maybe identify them by name where possible. (They could even be links to those modules' header or documentation).
- [x] Make features lists links to relevant modules
- [ ]~It would be nice if code example photo was a snippet from functional code.~
- [x] Might be good to change the "Installing" section to "Getting Started" or something, and including a note with a link to the DaisyExamples. There aren't currently any links to the examples repo, and as-is this would seem a little hard to figure out how to "make some sound!" with out any examples on how to do so.
Otherwise, it's a huge step up from the existing readme.
andrewikenberry
I accidentally rewrote the image paths to my fork, but it will make it easier to review. We'll just need to update those once it's merged.