search

electro-smith / json2daisy

Utility for converting JSON board definitions into valid, libDaisy compatible C++ board support files
MIT License
6 stars 1 forks source link

add flake8, mypy and generat test (disabled integration_test for now) #16

Closed dromer closed 11 months ago

dromer commented 11 months ago

Style and type hints are more consistent now and in line with python guidelines. I've only put an exception on the standard line-length, since 80 characters is quite short.

You'll probably want to check out the integration test to make sure it still works. I've never had it generate exactly the right output, so it always fails.

This probably closes #6 ?

dromer commented 11 months ago

@CorvusPrudens please chek

CorvusPrudens commented 11 months ago

I've made appropriate changes on an equivalent branch in this repo. The tests are to ensure changes are intentional, but are auto-generated. The idea is that as changes are made that affect the output, the tests verify what is expected. This may or may not be useful going forward, but they don't need to be disabled.

Feel free to merge those changes in. As long as the code output's behavior isn't actually changed, this PR should be mergeable.

dromer commented 11 months ago

Sure, looks good to me.

And yes I figured those test require some "manual" intervention, just that they were failing as is so I disabled them.