electro-smith / pd2dsy

Utility for converting Pure Data (Vanilla) patches to Daisy projects.
GNU General Public License v3.0
77 stars 11 forks source link

Petal 125B SM Support #23

Open CorvusPrudens opened 2 years ago

CorvusPrudens commented 2 years ago

This pull request adds support for the Petal 125B SM in addition to small QOL improvements.

The testing for this PR consisted of the petal_125b_sm_test.pd file. Tested components include:

All these are working as expected. Audio I/O seems perfectly functional as well. Notably, the expression input remains untested. My last expression pedal met a brutal end in a waterlogged basement.

CorvusPrudens commented 2 years ago

Petal125BSM Pure Data support

beserge commented 2 years ago

Documentation

Need documentation. The oopsy documentation was good. I'd copy from there.

Testing

Modified the example to test

Everything worked!

json

Audio Channels: 2. Not any more! We don't support "1 channel". Maybe a comment somewhere on that would be helpful.

Underscore versions of leds. led_1, aliased as led1. I think we had a similar conversation on the oopsy stuff. Maybe we changed this there and didn't back annotate it here.