search

electrode-io / electrode-confippet

node.js environment aware application configuration
Other
108 stars 18 forks source link

Mention node-config? #7

Closed wmertens closed 7 years ago

wmertens commented 7 years ago

Maybe I'm overstepping some bounds here, and I really appreciate Walmart open-sourcing Electrode, but shouldn't this project mention https://github.com/lorenwest/node-config in thanks for the obvious inspiration?

I have no stakes here, in fact I'm very deeply looking into replacing my home grown solution with Electrode because I was doing the same thing (configuration over code, remove all possible boilerplate).

jchip commented 7 years ago

Right, I used to directly reference node-config in the README for the default config files structure that's intentionally made to be the same as node-config. https://github.com/electrode-io/electrode-confippet/blob/f123f39bcbce9283aded6faef05f4b1e6cc3009f/README.md#default-config-files-settings

The README was rewritten and that reference was lost.

ananavati commented 7 years ago

@wmertens can we please close out on this issue now that a reference to node-config has been re-added to the README as part of this pr https://github.com/electrode-io/electrode-confippet/pull/9

wmertens commented 7 years ago

:+1: