electrode-io / electrode-native

A platform to ease integration&delivery of React Native apps in existing mobile applications
https://native.electrode.io
Other
726 stars 113 forks source link

Update ERN platform to support RN 0.67.5 #1869

Closed rthic23 closed 1 year ago

rthic23 commented 1 year ago
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

friederbluemle commented 1 year ago

Wow nice work @Karthiccc23 - Must have been quite tricky to get all of this set up locally for testing :+1:

Since this will be the biggest ERN update in a long time, I think it is important to double and triple check this - I'll try to run through a few variations myself in the coming days.

friederbluemle commented 1 year ago

update mavenPublisher in miniappRunner to query version from manifest - This commit looks like a nice "atomic" piece of work that can be submitted and merged as a separate PR right away, correct?

rthic23 commented 1 year ago

update mavenPublisher in miniappRunner to query version from manifest - This commit looks like a nice "atomic" piece of work that can be submitted and merged as a separate PR right away, correct?

yes here is a separate PR https://github.com/electrode-io/electrode-native/pull/1870 which will merged with manifest PR https://github.com/electrode-io/electrode-native-manifest/pull/237 controlling the versions.