search

electrode-io / electrode-native

A platform to ease integration&delivery of React Native apps in existing mobile applications
https://native.electrode.io
Other
723 stars 113 forks source link

Replace decompress-zip (fixes Node.js 17+) #1878

Closed friederbluemle closed 1 year ago

friederbluemle commented 1 year ago

Use adm-zip instead of decompress-zip for unzipping needs.

This fixes an issue with Node.js 17+ where the container generator would get stuck extracting the jsc/hermes aar file. Thanks @quanghoang0101 for helping to find the root cause. See #1837 for details.

adm-zip appears more actively maintained, and also has 0 dependencies (vs. 7 dependencies of decompress-zip).

Fixes #1837

quanghoang0101 commented 1 year ago

@friederbluemle Thanks for your quick update.