Fall back to username if no email available

electrode-io / electrode-ota-server

Electrode Over The Air Server for hot deployment of React Native and Cordova mobile apps

Other

204 stars 40 forks source link

Closed sdg9 closed 6 years ago

sdg9 commented 7 years ago

This PR makes it so code-push register works using username in place of email when no email is available.

This is a scenario I ran into with the way our github enterprise is configured.

It also fixes a bug where username is referenced when not defined

sdg9 commented 7 years ago

FYI I get this error when testing out using public github too

datvong-wm commented 6 years ago

Do you still need this PR? It currently has a merge conflict.

sdg9 commented 5 years ago

sorry late to respond, nope