fixing deployment history bug for similarly named deployments

electrode-io / electrode-ota-server

Electrode Over The Air Server for hot deployment of React Native and Cordova mobile apps

Other

204 stars 40 forks source link

fixing deployment history bug for similarly named deployments #80

Closed djergins closed 6 years ago

djergins commented 6 years ago

Hey all,

We have observed an issue with OTA where lets say you have an app with two deployment names where one name is a substring of the other, such as:

IntlProduction Production

The proposed changes will modify getDeploymentByAppAndName to not just short circuit to Production packages if they were wanting to get history for IntlProduction packages.

CLAassistant commented 6 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

djergin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}