electrode-io / electrode-ota-server

Electrode Over The Air Server for hot deployment of React Native and Cordova mobile apps
Other
204 stars 40 forks source link

hotfix - package update for a specific Id #81

Closed djergins closed 6 years ago

djergins commented 6 years ago

This pull request is to address the issue where currently, if an update check is run and the update params from the client are different than the package info for the latest package in deployment history, the updatePackage function will not incorrectly update the latest package.

The change made by this PR is, if the package passed in by the client has a package id, then that is the package that will be updated, because the main point of the update call in this context is to update the diffPackageMap. This will avoid the issue where the latest package in the deployment history gets erroneously updated with chaotic things being changed like appVersion and description, etc...

Let me know if there are any tweaks that I need to make.

Thanks!

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


djergin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.